Skip to content

fix(module:config): add itemsize config for tree select table (#8347) #8361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
EnochGao wants to merge 6 commits into
base: master
Choose a base branch
from
Open

fix(module:config): add itemsize config for tree select table (#8347) #8361

EnochGao wants to merge 6 commits into from

Conversation

@EnochGao
Copy link
Contributor

@EnochGao EnochGao commented Jan 18, 2024 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[X] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[X] Documentation content changes
[X] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

The gap at the bottom of the switch theme drop-down box is too large

Issue Number: #8347

What is the new behavior?

Normal clearance

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

none

ParsaArvanehPA
ParsaArvanehPA reviewed Jan 18, 2024
View reviewed changes
@EnochGao EnochGao requested a review from hsuanxyz as a code owner January 19, 2024 10:28
@codecov
Copy link

codecov bot commented Jan 19, 2024 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.18%. Comparing base (45ec83f) to head (c5ec1ed).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #8361   +/-   ##
=======================================
  Coverage   88.18%   88.18%           
=======================================
  Files         565      565           
  Lines       19864    19864           
  Branches     3184     3184           
=======================================
  Hits        17518    17518           
  Misses       2002     2002           
  Partials      344      344

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Nicoss54 Nicoss54 requested review from Nicoss54 and ParsaArvanehPA and removed request for ParsaArvanehPA February 8, 2024 14:51
@Nicoss54
Copy link
Collaborator

Nicoss54 commented Feb 8, 2024

@EnochGao thanks for your PR! Great works, it will take me some time to review all the change

But again thanks for your work

@HyperLife1119 HyperLife1119 mentioned this pull request Apr 17, 2024
Merged
3 tasks
Laffery
Laffery reviewed Oct 18, 2025
View reviewed changes
Copy link
Collaborator

@Laffery Laffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically LGTM, could you please rebase from master branch?

@EnochGao EnochGao requested a review from cipchk as a code owner October 22, 2025 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simplejason simplejason Awaiting requested review from simplejason simplejason is a code owner

@vthinkxie vthinkxie Awaiting requested review from vthinkxie vthinkxie is a code owner

@hsuanxyz hsuanxyz Awaiting requested review from hsuanxyz hsuanxyz is a code owner

@Nicoss54 Nicoss54 Awaiting requested review from Nicoss54

@HyperLife1119 HyperLife1119 Awaiting requested review from HyperLife1119

@cipchk cipchk Awaiting requested review from cipchk cipchk is a code owner

@ParsaArvanehPA ParsaArvanehPA Awaiting requested review from ParsaArvanehPA

@Laffery Laffery Awaiting requested review from Laffery

Assignees

@EnochGao EnochGao

Labels

Component: Select Component: Table Component: Tree Component: TreeSelect PR: need-rebase PR: partially-approved PR: target-minor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@EnochGao @Nicoss54 @Laffery @ParsaArvanehPA @HyperLife1119